-
Notifications
You must be signed in to change notification settings - Fork 231
WIP: Get Baremetal config from the Infrastructure CR #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@enxebre Here is another change required for Baremetal IPI deployment. We want to augment the BareMetalPlatformStatus struct https://github.com/openshift/api/blob/master/config/v1/types_infrastructure.go#L157 to include more BareMetal specific config (like this : openshift/api#444). But, I see that the OpenShift API code in the vendor directory is outdated. How do we update the version of the OpenShift API code pulled into the vendor directory here? |
|
Note that this is based on openshift/installer#2449 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Configuration required for the "metal3" deployment is now available in the Infrastructure Config Resource instead of the "metal3-config" ConfigMap.
|
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
superseded by #470 |
|
@sadasu: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Configuration required for the "metal3" deployment is now available
in the Infrastructure Config Resource instead of the "metal3-config"
ConfigMap.