Skip to content

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Oct 3, 2019

Configuration required for the "metal3" deployment is now available
in the Infrastructure Config Resource instead of the "metal3-config"
ConfigMap.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2019
@sadasu
Copy link
Contributor Author

sadasu commented Oct 3, 2019

@enxebre Here is another change required for Baremetal IPI deployment. We want to augment the BareMetalPlatformStatus struct https://github.com/openshift/api/blob/master/config/v1/types_infrastructure.go#L157 to include more BareMetal specific config (like this : openshift/api#444).

But, I see that the OpenShift API code in the vendor directory is outdated. How do we update the version of the OpenShift API code pulled into the vendor directory here?

@imain
Copy link

imain commented Oct 3, 2019

Note that this is based on openshift/installer#2449

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bison
You can assign the PR to them by writing /assign @bison in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Configuration required for the "metal3" deployment is now available
in the Infrastructure Config Resource instead of the "metal3-config"
ConfigMap.
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2019
@openshift-ci-robot
Copy link
Contributor

@sadasu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/goimports 9799021 link /test goimports
ci/prow/e2e-azure-operator 9799021 link /test e2e-azure-operator
ci/prow/govet 9799021 link /test govet
ci/prow/e2e-aws 9799021 link /test e2e-aws
ci/prow/e2e-aws-operator 9799021 link /test e2e-aws-operator
ci/prow/images 9799021 link /test images
ci/prow/e2e-aws-scaleup-rhel7 9799021 link /test e2e-aws-scaleup-rhel7
ci/prow/unit 9799021 link /test unit
ci/prow/e2e-aws-upgrade 9799021 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Jan 23, 2020

superseded by #470

@enxebre enxebre closed this Jan 23, 2020
@openshift-ci-robot
Copy link
Contributor

@sadasu: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants